Skip to content

API: separate querysets from API V2 and V3 - #11586

Merged
stsewd merged 6 commits into
mainfrom
allow-public-resources-api-corporate
Jan 13, 2025
Merged

stsewd merged 6 commits into
mainfrom
allow-public-resources-api-corporate

Conversation

@stsewd

@stsewd stsewd commented Sep 5, 2024

Copy link
Copy Markdown
Member

This allows us to override just the v2 querysets on .com, since we want to share the same logic as .org for v3.

ref readthedocs/ext-theme#154

@stsewd
stsewd marked this pull request as ready for review September 5, 2024 20:07
@stsewd
stsewd requested a review from a team as a code owner September 5, 2024 20:07
@stsewd
stsewd requested a review from ericholscher September 5, 2024 20:07

@ericholscher ericholscher left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I actually like this implementation a lot, since it makes API v3 the same across our sites, which feels like a huge simplification 💯

@humitos

humitos commented Sep 9, 2024

Copy link
Copy Markdown
Member

I actually like this implementation a lot, since it makes API v3 the same across our sites, which feels like a huge simplification 💯

Agreed! 👍🏼

Comment thread readthedocs/builds/querysets.py
@humitos

humitos commented Sep 10, 2024

Copy link
Copy Markdown
Member

@humitos humitos added the Status: blocked Issue is blocked on another issue label Sep 10, 2024
@stsewd stsewd removed the Status: blocked Issue is blocked on another issue label Jan 13, 2025
@stsewd
stsewd merged commit ce640c4 into main Jan 13, 2025
@stsewd
stsewd deleted the allow-public-resources-api-corporate branch January 13, 2025 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants